Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config to be compatible with pylint>=2.14 #1595

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Update config to be compatible with pylint>=2.14 #1595

merged 4 commits into from
Jun 8, 2022

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jun 7, 2022 •
edited
Loading

Signed-off-by: Deepyaman Datta deepyaman.datta@utexas.edu

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@deepyaman
Remove "bad-continuation" rule removed from pylint
7fe20f6 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Load "pylint.extensions.no_self_use" for pylint>=2.14
1faec82 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Ignore pylint warning from testing context manager
4c49868 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Ignore the "unnecessary" lambda assignment warning
015c802 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman changed the title Remove "bad-continuation" rule removed from pylint Update config to be compatible with pylint>=2.14 Jun 7, 2022
@deepyaman deepyaman marked this pull request as ready for review June 7, 2022 23:04
@deepyaman deepyaman requested a review from idanov as a code owner June 7, 2022 23:04
@deepyaman deepyaman mentioned this pull request Jun 7, 2022
Merged
5 tasks
@merelcht merelcht requested a review from antonymilne June 8, 2022 10:43
merelcht
merelcht approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @deepyaman !! 🏆

AhdraMeraliQB
AhdraMeraliQB approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks for picking this up!

@noklam noklam merged commit 8f4b81a into kedro-org:main Jun 8, 2022
@deepyaman deepyaman deleted the patch-6 branch June 8, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@merelcht merelcht merelcht approved these changes

@idanov idanov Awaiting requested review from idanov

@antonymilne antonymilne Awaiting requested review from antonymilne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepyaman @merelcht @AhdraMeraliQB @noklam