Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.18.11 #2745

Merged
merged 18 commits into from
Jul 3, 2023
Merged

Release 0.18.11 #2745

merged 18 commits into from
Jul 3, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Jun 28, 2023 •
edited by noklam
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Release PR for 0.18.11

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

astrojuanlu
astrojuanlu reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhdraMeraliQB! Added one comment.

Also, if we have some extra time tomorrow, I'd love to evaluate the possibility of fitting #2742 (discussion: #2270 (comment) cc @noklam)

RELEASE.md Show resolved Hide resolved
@deepyaman
Copy link
Member

deepyaman commented Jun 30, 2023 •
edited
Loading

@AhdraMeraliQB #2747 should go in (as per https://kedro-org.slack.com/archives/C054U0LJLAC/p1688061020135979?thread_ts=1687950117.495209&cid=C054U0LJLAC, discussed with @astrojuanlu yesterday); this is necessary to make sure users don't get flooded with warnings.

Would you be able to take a look/approve it?

deepyaman
deepyaman reviewed Jun 30, 2023
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
deepyaman
deepyaman reviewed Jun 30, 2023
View reviewed changes
CITATION.cff Outdated Show resolved Hide resolved
AhdraMeraliQB and others added 11 commits June 30, 2023 16:59
@AhdraMeraliQB
Update release date in CITATION.cff
8e372b1 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Rename old version to 0.18.11 where relevant
a2d690f 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Add Upcoming release section to RELEASE.md
9bbd3d2 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Fix prepopulated TOC
d0e7d5b 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Fix prepopulated TOC
256d699 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@stichbury @AhdraMeraliQB
update release notes with documentation details
c147c73 
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Add note of deprecation warning to RELEASE.md
dfb2f32 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@deepyaman @AhdraMeraliQB
Do not unsuppress DeprecationWarnings with Kedro (#2747)
2fa8334 
* Do not unsuppress `DeprecationWarning`s with Kedro

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Remove unused import

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

---------

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@deepyaman @AhdraMeraliQB
Update RELEASE.md with deprecation table
3293d70 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@deepyaman @AhdraMeraliQB
Update CITATION.cff
aa6ead4 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Update CITATION.cff
45efad5 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
astrojuanlu
astrojuanlu approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one last comment!

docs/source/configuration/advanced_configuration.md Outdated Show resolved Hide resolved
stichbury
stichbury approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 🌟

@AhdraMeraliQB @stichbury
Update docs/source/configuration/advanced_configuration.md
b570694 
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
noklam
noklam approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We still need to wait for the plugin release go first to make sure docs change in datasets are there.

RELEASE.md Show resolved Hide resolved
docs/source/tutorial/tutorial_template.md Outdated Show resolved Hide resolved
astrojuanlu
astrojuanlu reviewed Jul 3, 2023
View reviewed changes
RELEASE.md Show resolved Hide resolved
@astrojuanlu
Add community contributions
6c4c7e3 
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu
Add Prefect 2.0 docs update to changelog
977120d 
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@noklam
Copy link
Contributor

noklam commented Jul 3, 2023

Waiting for #2679

@AhdraMeraliQB AhdraMeraliQB merged commit 8065fb0 into main Jul 3, 2023
34 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the release/0.18.11 branch July 3, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepyaman deepyaman deepyaman left review comments

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@stichbury stichbury stichbury approved these changes

@noklam noklam noklam approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@idanov idanov Awaiting requested review from idanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AhdraMeraliQB @deepyaman @noklam @astrojuanlu @stichbury