Do not unsuppress DeprecationWarnings with Kedro
#2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
5 tasks
astrojuanlu
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
👍🏽
Although I'd note that, if users import kedro.extras.logging, they'll have a similar problem:
kedro/kedro/extras/logging/__init__.py
Line 10 in dde360a
AhdraMeraliQB
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Do not unsuppress `DeprecationWarning`s with Kedro Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Remove unused import Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
added a commit
that referenced
this pull request
Jul 3, 2023
* Update release date in CITATION.cff Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Rename old version to 0.18.11 where relevant Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add Upcoming release section to RELEASE.md Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix prepopulated TOC Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix prepopulated TOC Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * update release notes with documentation details Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Add note of deprecation warning to RELEASE.md Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Do not unsuppress `DeprecationWarning`s with Kedro (#2747) * Do not unsuppress `DeprecationWarning`s with Kedro Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Remove unused import Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update RELEASE.md with deprecation table Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update CITATION.cff Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update CITATION.cff Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Update docs/source/configuration/advanced_configuration.md Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Update tutorial_template.md * Add community contributions Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add Prefect 2.0 docs update to changelog Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development notes
Closes #2744
Checklist
RELEASE.mdfile