-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React integration #11
Conversation
…ig and Django integration.
…+ manifest.json, add TODOs for Docker integration
⛷️ This looks really great. We'll probably have some rearranging of folders still but let's do that after this is merged. @thornycrackers will check this over and then let's merge it in. |
I cleaned up some code based off of @ashiazed 's suggestions here. |
…ev server, reduce webpack output to console
@thornycrackers can you review the Docker and Makefile integration for me? I'm curious what suggestions you have. Right now for local development running both BE + FE is required. I'd like to add CI for frontend linting, is the one |
@hyshka It looks good. The only thing I'd get picky over is using |
What do you two think of this first pass?
The Python code probably isn't up to your standards so definitely give me some feedback on how I can improve it.
Basically, I used Create React App to generate the initial code in
/src/
, then wrote my own webpack config to add Django integration withdjango-webpack-loader
. I set it up for now so the app should be viewable atlocalhost:8000/app
.I didn't commit any built files, and didn't add Docker yet, but for this to be viewable you need to run the webpack server
npm run start
and then open it up at the Django URL.Django webpack loader will append links to the generated webpack bundles in the
index.html
template. By default, for development, webpack will then try to load assets fromlocalhost:3000
which is why you need the webpack server running.