Workaround hardhat-gas-reporter bug with removing --deploy-fixture #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #2970 we introduced a workaround for a bug in hardhat-gas-reporter plugin cgewecke/hardhat-gas-reporter#86. It turned out that there is a much simpler workaround, which is based on just removing `--deploy-fixture` flag. With the flag removed it is required that we load a global snapshot of the deployment (`deployments.fixture()`) instead of loading a specific tag (`deployments.fixture(<tag>)`. Which we do anyway after one of a recent code updates. We removed all the traces of the previous workaround.
pdyraga
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we replace a previous workaround (#2970) for a bug in the
hardhat-gas-reporterplugin (cgewecke/hardhat-gas-reporter#86).It turned out that there is a much simpler workaround, which is based on just removing
--deploy-fixtureflag. With the flag removed it is required that we load a global snapshot of the deployment (deployments.fixture()) instead of loading a specific tag (deployments.fixture(<tag>). Which we do anyway after one of a recent code updates.