Adjustments to the wallet proposal generator #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we re-generate tBTC contract bindings to catch recent upgrades related to optimistic redemptions.
The optimistic redemption upgrade introduces a veto mechanism that enforces a processing delay on each redemption request. The exact delay value depends on the number of objections raised against the given redemption request. The `WalletProposalValidator` contract has been modified to include validation of that delay factor. Here we introduce the same for the redemption proposal generator. This ensures the generator issues proposals that conform the on-chain validation rules and coordination windows are not being wasted. See: keep-network/tbtc-v2#788
The `WalletProposalValidator` contract enforces the minimum age of a deposit that can become part of the proposal. Right now, the proposal generator misses this check and often produces invalid proposals that violate the on-chain minimum deposit age rule. Here we fix that.
# Conflicts: # pkg/tbtcpg/chain_test.go
tomaszslabon
reviewed
Mar 7, 2024
tomaszslabon
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: keep-network/tbtc-v2#781
Depends on: keep-network/tbtc-v2#788 (the
client-build-test-publishjob will become green once 788 is merged and a newtbtc-v2@developmentpackage withRedemptionWatchtowerartifact will be published to npm)The optimistic redemption upgrade introduces a veto mechanism (keep-network/tbtc-v2#788) that enforces a processing delay on each redemption request. The exact delay value depends on the number of objections raised against the given redemption request. The
WalletProposalValidatorcontract has been modified to include validation of that delay factor. The first change ed9c4ae introduces the same for the redemption proposal generator. This ensures the generator issues proposals that conform to the on-chain validation rules and coordination windows are not being wasted.By the way, we are taking an opportunity to optimize the deposit sweep proposal generation. The
WalletProposalValidatorcontract enforces the minimum age of a deposit that can become part of the proposal. The proposal generatorwas missing this check and was often producing invalid proposals that were violating the on-chain minimum deposit age rule. We fix that in 55be487.