This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Add Trezor wallet connector #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a known issue that Trezor's API will throw for larger network ID's. Next commit should fix that.
Much like our Ledger subprovider, this provider mitigates issues with the Trezor subprovider provided by 0x - namely, chainId's < 255 are not supported.
r-czajkowski
suggested changes
Jun 23, 2020
The `AbstractConnector` returns only first account by default. With our custom implementation of `TrezorConnector` allows users to get eg. 15 accounts and sotres the selected account. The `TrezorConnector` overrides a `getAccount` fn from the `AbstractConnector`, and this function returns a selected account instead of the first account.
The ChooseAccount component allows user to choose a any address from the hardware wallet.
Extracted the components from the `ConnectWalletDialog` component into separate functional components.
Pass a number of accounts arg to the `getAccounts` fn in the trezor provider and set to default value (15).
Removed unused variables, used a common functions.
ironng
reviewed
Jul 3, 2020
ironng
reviewed
Jul 3, 2020
ironng
reviewed
Jul 3, 2020
| {(chosenWallet.name && !active) && | ||
| <ConnectToWalletStep | ||
| wallet={chosenWallet} | ||
| error={error}onTryAgainClick={reconnectWallet} |
There was a problem hiding this comment.
Spacing and indentation is odd here but we can fix it when we do a pass with prettier
ironng
reviewed
Jul 3, 2020
Simplify default assignment and use specific type for param in jsdoc
ironng
approved these changes
Jul 3, 2020
|
@r-czajkowski going to merge - looks like you've addressed all your comments! 🙇♀️ If there is anything else we can do it on the heath-ledger one. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements wallet support for Trezor. It introduces a custom subprovider and connector, so as to support our internal testnet's chainId.
Depends on: #205
Epic: #177