This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Update version to 0.17.10-dev and tbtc.js to the latest range #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @keep-network/tbtc.js version 0.19.4 was already published we need to bump up the range for pulling following versions in CI.
Version 0.17.9 was already released so we need to start a new version.
michalinacienciala
suggested changes
Sep 30, 2021
| "dependencies": { | ||
| "@0x/subproviders": "^6.0.8", | ||
| "@keep-network/tbtc.js": ">0.19.4-pre <0.19.4-rc", | ||
| "@keep-network/tbtc.js": ">0.19.5-pre <0.19.5-rc", |
There was a problem hiding this comment.
We no longer release the -pre-tagged packages.
Suggested change
| "@keep-network/tbtc.js": ">0.19.5-pre <0.19.5-rc", | |
| "@keep-network/tbtc.js": ">0.19.5-rc <0.19.5-ropsten", |
And something that is outside of scope of this PR that I noticed when looking at the dependencies:
The dependencies in the package.json in @keep-network/tbtc.js don't refer to latest tbtc packages. I think we should use the "@keep-network/tbtc": ">1.1.2-dev <1.1.2-ropsten", dependency there, same as we use in coverage-pools. How do you think, @nkuba?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @keep-network/tbtc.js version 0.19.4 was already published we need to bump up the range for pulling following versions in CI.
tbtc-dapp version 0.17.9 was already released so we need to start a new version in the main branch.
Refs #401