This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Version Tether: Continuous packaging and versioning #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.12.0-pre series is the first one that will be auto-published on new contract deploys.
Not doing this was occasionally trying to run `npm` as if it was a file in the current working directory.
This interface is bundled with the tbtc artifacts, while BondedECDSAKeep comes from keep-ecdsa. Rather than depend on keep-ecdsa directly, for now the reference is updated to the interface. In fact, the interface is all that's necessary for tbtc.js to work correctly, since the ABI is bound to a per-deposit instance of the contract.
No need to include tests or other helper and utility files for the published package.
This script is very close to the one used in keep-core, keep-ecdsa, and tbtc, and will eventually be abstracted out once the commonalities and differences shake out.
Shadowfiend
force-pushed
the
version-tether
branch
2 times, most recently
from
e5e33df
to
ca85cd4
Compare
The repository_dispatch trigger is limited to the `redeploy` type for now.
sthompson22
approved these changes
Apr 1, 2020
| @@ -15,7 +15,7 @@ import DepositFactoryJSON from "@keep-network/tbtc/artifacts/DepositFactory.json | |||
| import TBTCTokenJSON from "@keep-network/tbtc/artifacts/TBTCToken.json" | |||
| import FeeRebateTokenJSON from "@keep-network/tbtc/artifacts/FeeRebateToken.json" | |||
| import VendingMachineJSON from "@keep-network/tbtc/artifacts/VendingMachine.json" | |||
| import BondedECDSAKeepJSON from "@keep-network/tbtc/artifacts/BondedECDSAKeep.json" | |||
| import IBondedECDSAKeepJSON from "@keep-network/tbtc/artifacts/IBondedECDSAKeep.json" | |||
There was a problem hiding this comment.
Can you add a bit of color here, just for my edification?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up the work in keep-core, keep-ecdsa, and tbtc to publish
new npm packages on contract migration. It adds the same functionality
to tbtc.js, and additionally updates the version string referencing tbtc to
properly integrate with tbtc's versioning.
The major changes are:
package.jsonis set to<version>-pre, with no numeric suffix.Bump and publish npm package, runs on mastermerge. This step updates the package version to
-pre.<number>, where<number>represents a new, unpublished version.In the process, references to keep-ecdsa contracts are also removed so that
tbtc.js can stay only directly dependent on tbtc.