Document optionally locked deposits #294
Conversation
mhluongo
force-pushed
the
document-optionally-locked-deposits
branch
from
a463a41
to
a44eee5
Compare
The state diagrams, and fee and redemption documentation need to be updated to reflect this change. Refs #293.
mhluongo
force-pushed
the
document-optionally-locked-deposits
branch
from
5d0faaa
to
c6e1f6b
Compare
Preparing for a significant rewrite. Refs #293.
mhluongo
force-pushed
the
document-optionally-locked-deposits
branch
11 times, most recently
from
3bc5a83
to
c065b40
Compare
mhluongo
force-pushed
the
document-optionally-locked-deposits
branch
4 times, most recently
from
dbd358d
to
41217e1
Compare
mhluongo
force-pushed
the
document-optionally-locked-deposits
branch
from
41217e1
to
5b43ae2
Compare
|
@Shadowfiend would love your eyes on this |
|
Ahhhh just realized I need to update the state diagrams as well 😩 EDIT: And the appendix. All I want to do is replace the damn price feed 😭 |
|
Okay folks, I pulled this from In Progress (the sprint board is for issues, not PRs) and will be driving it to merge + splitting out follow-up work as needed. For now, we're continuing to track everything in #293, but that may get broken down into further issues depending on how we end up proceeding here. I'm going to leave some notes and, depending on @mhluongo's preference, may pull in some of the changes that have already been suggested + +1ed in the discussion so far. Ready to get this particular PR merged, and see if we can wrap up the overall work soon! |
There was a problem hiding this comment.
Ok, left a few comments, some on open notes, some new ones, several on punting things to follow-up work.
@mhluongo I'm interested in you looking through any open change suggestions and +1ing any that you'd like. Then I can commit those on your behalf. Likewise, I'd be interested in +1s or -1s on punting things to follow-up issues. Then I can create those on your behalf, and we can briefly discuss the best way to sequence them. Finally, we can go through any remaining bits (maybe sync?) and see if we can wrap this puppy up. Wdyt?
This is a bundle of light clarifications and fixes to typos. Co-Authored-By: Georgios Konstantopoulos <me@gakonst.com>
Shadowfiend
force-pushed
the
document-optionally-locked-deposits
branch
from
7cccb4b
to
e19088a
Compare
There was a problem hiding this comment.
All remarks have either been addressed, dismissed, or captured as additional tasks under the original issue @ #293. We'll want to move through the rest of those tasks diligently, but that wraps up work on this PR.
Begin documenting a two-phase minting process allowing all deposits to be optionally "locked" to the depositor, or redeemable by anyone (as in the current system).
This work will have a significant impact on deposit UX, allowing dApps to let a depositor to more easily walk away while work accumulates on their Bitcoin transaction.
Refs #293, blocks #254.