Ft username store contract #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mubarak23
commented
Apr 11, 2024
•
mubarak23
commented
- issue
- follows contribution guide
- code change includes tests
- breaking change
- Starknet smart contract for username store
- Caller of the contract can claim a name, the name is link to his address
- Caller of the contract can transfer a name, if he/she is the one that claim the name
b-j-roberts
requested changes
Apr 11, 2024
|
@b-j-roberts i have fix the changes as requested , kindly review them |
b-j-roberts
requested changes
Apr 12, 2024
|
@b-j-roberts kindly review the updated test functions |
This was referenced Aug 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.