Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded cairo to 2.7.0 & Implement OP_SHA256 #117

Merged

Conversation

supreme2580
Copy link
Contributor

@supreme2580 supreme2580 commented Aug 7, 2024

Upgraded to cairo 2.7.0 and implemented OP_SHA256

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shinigami ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:58am

@supreme2580
Copy link
Contributor Author

@b-j-roberts it may seem like I touched multiple files, that only happened because I ran scarb fmt before pushing and it formatted other files

@b-j-roberts
Copy link
Contributor

Looks good, I'll merge ASAP.
Would you be interested in implementing OP_SHA256 ontop of this PR? You can start on that whenever if so.

I'd recommend an online tool like this to get sample test data https://emn178.github.io/online-tools/sha256.html

@supreme2580
Copy link
Contributor Author

@b-j-roberts I will implement OP_SHA256 ontop this PR, thank you

@supreme2580
Copy link
Contributor Author

Hi @b-j-roberts I have just implemented OP_SHA256

src/opcodes/tests/test_stack.cairo Outdated Show resolved Hide resolved
@supreme2580 supreme2580 changed the title upgraded cairo Upgraded cairo to 2.7.0 & Implement OP_SHA256 Aug 12, 2024
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! First hash function down 👍

@b-j-roberts b-j-roberts merged commit 5c3b312 into keep-starknet-strange:main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants