Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click context menu doesn't show keyboard shortcuts anymore #1588

Closed
hllmtl opened this issue Mar 1, 2018 · 2 comments · Fixed by #2431
Closed

Right click context menu doesn't show keyboard shortcuts anymore #1588

hllmtl opened this issue Mar 1, 2018 · 2 comments · Fixed by #2431
Assignees
Labels
Milestone

Comments

@hllmtl
Copy link

hllmtl commented Mar 1, 2018

Expected Behavior

I expected right click context menu to show keyboard shortcuts like it used to do in 2.2.4.

Current Behavior

Keyboard shortcuts are not shown in the right click context menu in 2.3.0, only in the "Entries" dropdown at the top.

Context

To be honest I'm not sure if this change is intended or not, but I didn't see anything about it in #1305 or anywhere else.

Debug Info

KeePassXC - Version 2.3.0
Revision: 4c0ed74

Libraries:

  • Qt 5.10.1
  • libgcrypt 1.8.2

Operating system: Windows 10 (10.0)
CPU architecture: x86_64
Kernel: winnt 10.0.16299

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey
@Wazhai
Copy link

Wazhai commented Oct 25, 2018

It would be good if we were to get some clarification on whether this is a bug or intended. Version 2.3.4 is still affected. I personally don't see a reason to hide the shortcuts from the context menu and really miss them.

@droidmonkey droidmonkey added the ux label Oct 25, 2018
@droidmonkey
Copy link
Member

This one slipped by me. I never noticed the shortcuts gone, that was not intentional.

@droidmonkey droidmonkey added this to the v2.4.0 milestone Oct 25, 2018
@droidmonkey droidmonkey self-assigned this Oct 25, 2018
droidmonkey added a commit that referenced this issue Oct 28, 2018
* Cleanup entry change notification with entryview focus in/out
* Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action"
including SHIFT
* Change Copy URL shortcut to CTRL+U to conform with "copy" without
SHIFT
* Entry specific toolbar and menu items are disabled unless the entry
row has focus (prevents unintended actions)

* Fix #1588 - show keyboard shortcuts in context menu
* Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V
* Fix #2096 - Add (CTRL+F) to search bar background
droidmonkey added a commit that referenced this issue Nov 15, 2018
* Cleanup entry change notification with entryview focus in/out
* Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action"
including SHIFT
* Change Copy URL shortcut to CTRL+U to conform with "copy" without
SHIFT
* Entry specific toolbar and menu items are disabled unless the entry
row has focus (prevents unintended actions)

* Fix #1588 - show keyboard shortcuts in context menu
* Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V
* Fix #2096 - Add (CTRL+F) to search bar background
droidmonkey added a commit that referenced this issue Nov 16, 2018
* Cleanup entry change notification with entryview focus in/out
* Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action" 
including SHIFT
* Change Copy URL shortcut to CTRL+U to conform with "copy" without SHIFT
* Entry specific toolbar and menu items are disabled unless the entry
row has focus (prevents unintended actions)
* Reword security setting for password visibility in entry edit view
* Add shortcut to hide/unhide usernames (CTRL+SHIFT+B)
* Organize entry menu

* Fix #1588 - show keyboard shortcuts in context menu
* Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V
* Fix #2096 - Add (CTRL+F) to search bar background
* Fix #2031 & Fix #2266 - add shortcut to hide/unhide passwords (CTRL+SHIFT+C)
* Fix #2166 - Add reveal password button to entry preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants