Fix multiple issues with entry keyboard shortcuts #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
b62cb41
to
d8ca532
Compare
|
Ready for review! |
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
8c4fd43
to
5c504be
Compare
weslly
suggested changes
Oct 28, 2018
|
@weslly good catch, updated and tried to make the gui tests even more reliable... |
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
8a860c0
to
002f743
Compare
weslly
reviewed
Oct 28, 2018
src/gui/SearchWidget.cpp
Outdated
| new QShortcut(Qt::Key_Escape, m_ui->searchEdit, SLOT(clear()), nullptr, Qt::ApplicationShortcut); | ||
|
|
||
| m_ui->searchEdit->setPlaceholderText(tr("Search (%1)...", "Search placeholder text, %1 is the keyboard shortcut") | ||
| .arg(QKeySequence(QKeySequence::Find).toString(), QKeySequence::NativeText)); |
There was a problem hiding this comment.
@droidmonkey Still returning CTRL
QKeySequence::NativeText should be an argument of .toString() instead of tr().arg().
There was a problem hiding this comment.
Man I am striking out today! Good catch 😢
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
002f743
to
cd98cd2
Compare
weslly
approved these changes
Oct 28, 2018
* Cleanup entry change notification with entryview focus in/out * Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action" including SHIFT * Change Copy URL shortcut to CTRL+U to conform with "copy" without SHIFT * Entry specific toolbar and menu items are disabled unless the entry row has focus (prevents unintended actions) * Fix #1588 - show keyboard shortcuts in context menu * Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V * Fix #2096 - Add (CTRL+F) to search bar background
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
cd98cd2
to
359d234
Compare
droidmonkey
force-pushed
the
fix/shortcuts
branch
from
359d234
to
2bc4e64
Compare
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup entry change notification with entryview focus in/out
Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action"
including SHIFT
Change Copy URL shortcut to CTRL+U to conform with "copy" without
SHIFT
Entry specific toolbar and menu items are disabled unless the entry
row has focus (prevents unintended actions)
Reword security setting for password visibility in entry edit view
Shortcut to hide/unhide usernames (CTRL+SHIFT+B)
Fix Right click context menu doesn't show keyboard shortcuts anymore #1588 - show keyboard shortcuts in context menu
Fix CTRL+V after searching doesn't start autotype anymore #2403 - Change auto-type shortcut to CTRL + SHIFT + V
Fix Add keyboard shortcut to search bar background text #2096 - Add (CTRL+F) to search bar background
Fix shortcut to hide/unhide usernames and passwords #2031 & Fix Allow to temporarily show individual passwords #2266 - shortcut to hide/unhide passwords (CTRL+SHIFT+C)
Fix Add reveal password button to details pane #2166 - Add reveal password button to entry preview
Motivation and context
The previous way these interactions were handled was rather fragile and required 3 different signal/slot interactions between 3-4 objects.
How has this been tested?
Manually and unit tests
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]