Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues with entry keyboard shortcuts #2431

Merged
merged 6 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@droidmonkey
Copy link
Member

droidmonkey commented Oct 28, 2018

Description

  • Cleanup entry change notification with entryview focus in/out

  • Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action"
    including SHIFT

  • Change Copy URL shortcut to CTRL+U to conform with "copy" without
    SHIFT

  • Entry specific toolbar and menu items are disabled unless the entry
    row has focus (prevents unintended actions)

  • Reword security setting for password visibility in entry edit view

  • Shortcut to hide/unhide usernames (CTRL+SHIFT+B)

  • Fix #1588 - show keyboard shortcuts in context menu

  • Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V

  • Fix #2096 - Add (CTRL+F) to search bar background

  • Fix #2031 & Fix #2266 - shortcut to hide/unhide passwords (CTRL+SHIFT+C)

  • Fix #2166 - Add reveal password button to entry preview

Motivation and context

The previous way these interactions were handled was rather fragile and required 3 different signal/slot interactions between 3-4 objects.

How has this been tested?

Manually and unit tests

Screenshots (if appropriate):

entries_menu

preview_panel_passtoggle

security_options

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation and I have updated it accordingly.

@droidmonkey droidmonkey added the ux label Oct 28, 2018

@droidmonkey droidmonkey added this to the v2.4.0 milestone Oct 28, 2018

@droidmonkey droidmonkey requested review from weslly, phoerious and louib Oct 28, 2018

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from b62cb41 to d8ca532 Oct 28, 2018

@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Oct 28, 2018

Ready for review!

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from 8c4fd43 to 5c504be Oct 28, 2018

@weslly
Copy link
Member

weslly left a comment

image

The search bar shortcut text should be changed from CTRL to ⌘ on macOS.

@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Oct 28, 2018

@weslly good catch, updated and tried to make the gui tests even more reliable...

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from 8a860c0 to 002f743 Oct 28, 2018

new QShortcut(Qt::Key_Escape, m_ui->searchEdit, SLOT(clear()), nullptr, Qt::ApplicationShortcut);

m_ui->searchEdit->setPlaceholderText(tr("Search (%1)...", "Search placeholder text, %1 is the keyboard shortcut")
.arg(QKeySequence(QKeySequence::Find).toString(), QKeySequence::NativeText));

This comment has been minimized.

Copy link
@weslly

weslly Oct 28, 2018

Member

@droidmonkey Still returning CTRL

QKeySequence::NativeText should be an argument of .toString() instead of tr().arg().

This comment has been minimized.

Copy link
@droidmonkey

droidmonkey Oct 28, 2018

Author Member

Man I am striking out today! Good catch 😢

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from 002f743 to cd98cd2 Oct 28, 2018

@weslly

weslly approved these changes Oct 28, 2018

droidmonkey added some commits Oct 28, 2018

Fix multiple issues with entry keyboard shortcuts
* Cleanup entry change notification with entryview focus in/out
* Change Open URL shortcut to CTRL+SHIFT+U to conform with an "action"
including SHIFT
* Change Copy URL shortcut to CTRL+U to conform with "copy" without
SHIFT
* Entry specific toolbar and menu items are disabled unless the entry
row has focus (prevents unintended actions)

* Fix #1588 - show keyboard shortcuts in context menu
* Fix #2403 - Change auto-type shortcut to CTRL + SHIFT + V
* Fix #2096 - Add (CTRL+F) to search bar background
Correct entry selection detection, add more features
* Reword security setting for password visibility in entry edit view
* Shortcut to hide/unhide usernames (CTRL+SHIFT+B)
* Fix #2031 & Fix #2266 - shortcut to hide/unhide passwords (CTRL+SHIFT+C)
* Fix #2166 - Add reveal password button to entry preview

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from cd98cd2 to 359d234 Nov 15, 2018

@droidmonkey droidmonkey force-pushed the fix/shortcuts branch from 359d234 to 2bc4e64 Nov 16, 2018

@droidmonkey droidmonkey merged commit ee9c71e into develop Nov 16, 2018

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey deleted the fix/shortcuts branch Nov 16, 2018

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.