Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.4.2 Clicking on notification area icon no longer hides the window #3256

Closed
FuturePilot opened this issue Jun 11, 2019 · 1 comment
Closed

2.4.2 Clicking on notification area icon no longer hides the window #3256

FuturePilot opened this issue Jun 11, 2019 · 1 comment
Labels
bug platform: Linux
Milestone
v2.4.3

Comments

@FuturePilot
Copy link

Expected Behavior

Clicking the icon in the notification area should hide the window if it is currently open.

Current Behavior

Clicking the icon in the notification area does nothing if the window is currently open.

Steps to Reproduce

  1. Enable "Show a system tray icon" in Settings
  2. Click the icon in the notification area
  3. Nothing happens

This is a regression from 2.4.1 behavior. Running Kubuntu 19.04

Debug Info

KeePassXC - Version 2.4.2
Revision: a775031

Qt 5.12.2
Debugging mode is disabled.

Operating system: Ubuntu 19.04
CPU architecture: x86_64
Kernel: linux 5.0.0-16-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:
libgcrypt 1.8.4
@droidmonkey
Copy link
Member

Ahh I found the logic error. On Windows clicking the tray icon causes the application window to unfocus. This does not happen in KDE Plasma so it does not trigger the tray action. Interestingly double clicking the tray icon does not work at all. I believe this to be a Qt bug.

@droidmonkey droidmonkey added this to the v2.4.3 milestone Jun 11, 2019
@droidmonkey droidmonkey mentioned this issue Jun 11, 2019
Merged
phoerious pushed a commit that referenced this issue Jun 11, 2019
@droidmonkey @phoerious
Fix clicking tray icon to toggle window on Linux (#3258)
72de3cf 
KDE does not take focus from the current active window when the tray
icon is clicked. This prevented toggling the window (always called bringToFront).
Checking if the window is active corrects this issue.

Fixes #3256, fixes #3214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug platform: Linux
Projects
None yet
Milestone
v2.4.3
Development

No branches or pull requests
3 participants
@phoerious @droidmonkey @FuturePilot