Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking tray icon to toggle window on Linux #3258

Merged
merged 1 commit into from Jun 11, 2019

Conversation

2 participants
@droidmonkey
Copy link
Member

commented Jun 11, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • KDE does not take focus from the current active window when the tray icon is clicked. This prevented toggling the window (always called bringToFront). Checking if the window is active corrects this issue.
  • Fixes #3256 and Fixes #3214

Testing strategy

Tested on Ubuntu 19.04 KDE. Unity/Gnome does not support click activation of the tray icon (the context menu is always shown).

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
Fix clicking tray icon to toggle window on Linux
* KDE does not take focus from the current active window when the tray icon is clicked. This prevented toggling the window (always called bringToFront). Checking if the window is active corrects this issue.

@droidmonkey droidmonkey added this to the v2.4.3 milestone Jun 11, 2019

@droidmonkey droidmonkey requested a review from phoerious Jun 11, 2019

@phoerious phoerious merged commit 72de3cf into release/2.4.3 Jun 11, 2019

3 checks passed

MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@phoerious phoerious deleted the hotfix/trayicon branch Jun 11, 2019

phoerious added a commit that referenced this pull request Jun 11, 2019

Release 2.4.3
- Fix library loading issues in the Snap and macOS releases [#3247]
- Fix various keyboard navigation issues [#3248]
- Fix main window toggling regression when clicking the tray icon on KDE [#3258]
- Add documentation for keyboard shortcuts to source code distribution [#3215]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.