Show all url schemas in entry view #1768
Conversation
|
Do we want to display the full content of the URL field? By removing the call to The other PR use this second approach #1489 |
|
I forgot about that other PR. That one is just a bandaid to the larger problem. We were erroneously filtering and modifying the URL for display (entry->displayUrl()). This one moves us closer to better behavior and cleaner interfaces. As I noted in the description, there still exists some ugly behavior that is dependent on the icon download code. |
|
Will this show, for example, |
droidmonkey
force-pushed
the
fix/display-url
branch
from
bb705e8
to
964eaa1
Compare
|
@tobiasboyd sorry for the delay, yes this PR displays SSH, HTTP, every url correctly. |
src/gui/DatabaseWidget.cpp
Outdated
| } | ||
|
|
||
| if (urlString.startsWith("cmd://")) { | ||
| if (entry->url().startsWith("cmd://")) { |
There was a problem hiding this comment.
We should call resolvePlaceholders before this check (like it was done before)
Example scenario:
The current entry has the url set to {REF:A@I:<uuid>} (a reference to another url field)
The other entry has the url field set to cmd://firefox https://github.com
In the current entry this check will be false (but should be true since the referred url does contains cmd://), the url will be treated like a http url and the github.com link will be opened in the default browser (wrong behavior)
In the other entry the url will be correctly treated like a cmd and the execution alert below will be executed
droidmonkey
force-pushed
the
fix/display-url
branch
from
964eaa1
to
613a7e3
Compare
|
I moved this to v2.3.4 since it is a relatively minor change |
droidmonkey
force-pushed
the
fix/display-url
branch
from
613a7e3
to
e0d81c1
Compare
|
I reverted the removal and also fixed an issue with not validating user input when generating UUID's. |
|
ping @TheZ3ro |
* Fix UUID being built improperly with invalid user input
droidmonkey
force-pushed
the
fix/display-url
branch
from
e0d81c1
to
a5aaa42
Compare
- Show all URL schemes in entry view [#1768] - Disable merge when database is locked [#1975] - Fix intermittent crashes with favorite icon downloads [#1980] - Provide potential crash warning to Qt 5.5.x users [#2211] - Disable apply button when creating new entry/group to prevent data loss [#2204] - Allow for 12 hour timeout to lock idle database [#2173] - Multiple SSH Agent fixes [#1981, #2117] - Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185] - Fix browser proxy application not closing properly [#2142] - Add real names and Patreon supporters to about dialog [#2214] - Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214] - Enhancements to release-tool to appsign intermediate build products [#2101]
Description
Fixes #1424
Note: There is still bad behavior in the details view when you have a cmd:// url it will attempt to open a url that is embedded in the command. This is a holdover for icon downloading and can be corrected once icon downloading has the ability to specify arbitrary urls.
How has this been tested?
Manually
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]