Download favorite icon of entry url and add to the custom icon registry

[droidmonkey]

No description provided.

[droidmonkey]

I would still like to extend this functionality by adding a right click menu option to fetch the icon, maybe you can code that with this baseline as a start? I greatly simplified the functions.

Also you can wish all you want, but if you don't tell anyone you are working on something then no one will know. Recommend opening an issue next time to announce your intentions.

[magkopian]

I know, I should have opened an issue but I was a bit overexcited about that feature and I completely omitted it. And also, actually that was the very first time I was working with qt and I wasn't exactly sure if I would be able to do it. In fact, I'm a PHP developer but I wanted that feature so much so I decided to give it a try anyway, even though I didn't know much about c++ / qt applications and see how it goes. So, that's actually the major reason I didn't open an issue, I didn't want to get people excited about this and then just say sorry I can't do it.

Anyway, I just found it funny that we were working on the exact same feature the exact same time, while no one had the idea about implementing something similar it in the past, what are the odds. It was a fun experience though, it was interesting working on something desktop instead of web based for a change.

[droidmonkey]

Hehe, it has actually been developed two other times on the original KeePassX repo, just never incorporated. I took one of the original pull requests and made it better and incorporated it in. I look forward to your future contributions!