Add feature to ignore entries for HTTP-Auth Logins #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in favor of this, the two options conflict with each other and can be simultaneously selected. Prefer a drop down selection. |
droidmonkey
force-pushed
the
develop
branch
from
3b20a35
to
927ace7
Compare
droidmonkey
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this feature since there is a real use-case for me and therefore maybe others as well.
I work in different environments - from some I need to supply basic-auth credentials when accessing certain websites in addition to the webpage credentials. I usually have two distinct entries for the site in question. However if one has to supply http basic-auth credentials one still has two entries and keepassxc-browser doesnt know which one to choose although only one of those entries is applicable for basic-auth which is slowing down my process.. The added feature enables the user - in addition to the already present option to mark entries as ONLY_HTTP_AUTH - to mark an entry with the opposite attribute - NO_HTTP_AUTH...
Screenshots
Testing strategy
Tested on my actual setup.. Only the correct login for the use-case remains.
http-auth-entries only for http-auth-sites instead of all entries available for a given url
Type of change