Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert async Access Confirm Dialog #8665

Merged

Conversation

varjolintu
Copy link
Member

Reverts #8273 because it clearly does not work properly on every operating system. This feature must be remade.

Fixes #8634.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 64.29% // Head: 64.39% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (dd4c3d5) compared to base (69f05d4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8665      +/-   ##
===========================================
+ Coverage    64.29%   64.39%   +0.10%     
===========================================
  Files          341      341              
  Lines        44336    44242      -94     
===========================================
- Hits         28503    28488      -15     
+ Misses       15833    15754      -79     
Impacted Files Coverage Δ
src/browser/BrowserAccessControlDialog.cpp 0.00% <0.00%> (ø)
src/browser/BrowserAction.cpp 9.20% <0.00%> (+0.23%) ⬆️
src/browser/BrowserAction.h 100.00% <ø> (ø)
src/browser/BrowserService.cpp 27.10% <0.00%> (+1.47%) ⬆️
src/browser/BrowserService.h 100.00% <ø> (ø)
src/gui/Clipboard.cpp 78.95% <0.00%> (-7.02%) ⬇️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 56.06% <0.00%> (-3.03%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️
src/core/FileWatcher.cpp 86.75% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey force-pushed the fix/revert_async_confirm_dialog branch from 8374bb7 to dd4c3d5 Compare October 28, 2022 11:33
@droidmonkey droidmonkey merged commit 37baa6f into keepassxreboot:develop Oct 29, 2022
@varjolintu varjolintu deleted the fix/revert_async_confirm_dialog branch October 29, 2022 11:44
@droidmonkey droidmonkey mentioned this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrade to 2.7.3 on Linux, cannot connect to browser
4 participants