Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve empty list mesage #1354

Closed
chalkos opened this issue Sep 28, 2018 · 1 comment
Closed

Improve empty list mesage #1354

chalkos opened this issue Sep 28, 2018 · 1 comment
Assignees
@chalkos
Labels
enhancement
Milestone
3.0

Comments

@chalkos
Copy link
Contributor

chalkos commented Sep 28, 2018

When the user searches and there are no results, a message is shown to re-check the search, but this message is also shown even when the user did not search anything (ie: there really is nothing to show, or there are pre-filters restricting the search and there are no results).

This may be confusing to the user. RODA could show a different 'no-results' message when the user did not change the search parameters.
@chalkos chalkos added this to the 2.3.0 milestone Sep 28, 2018
@chalkos chalkos self-assigned this Sep 28, 2018
chalkos added a commit that referenced this issue Oct 1, 2018
@chalkos
fixes #1354 by showing a different message when there are no results …
923eeb1 
…and the user did not change the search parameters
@chalkos
Copy link
Contributor Author

chalkos commented Oct 1, 2018

@luis100 there might be a better wording to use here, take a look and let me know if something occurs to you

@chalkos chalkos closed this as completed Oct 1, 2018
luis100 pushed a commit that referenced this issue Oct 3, 2018
@chalkos @luis100
fixes #1354 by showing a different message when there are no results …
aad87ed 
…and the user did not change the search parameters
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalkos chalkos

Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@chalkos