Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdbxweb creates corrupted kdbx 4 database #49

Open
AlBundy33 opened this issue Mar 2, 2023 · 2 comments
Open

kdbxweb creates corrupted kdbx 4 database #49

AlBundy33 opened this issue Mar 2, 2023 · 2 comments
Labels
Type ◦ Bug Something isn't working ⚠ Urgent Requires urgent attention

Comments

@AlBundy33
Copy link

see
keeweb/keeweb#2001
https://sourceforge.net/p/keepass/bugs/2231/
https://keepass.info/help/kb/kdbx_4.1.html#cd_lastmod

after reading the source I would assume that the issue is maybe here

XmlUtils.setDate(

this line calls setDate

export function setDate(node: Node, date: Date | undefined, binary = false): void {

with only two arguments and therefore binary is false and the date is written as iso-string instead of base64

because the lastModificationTime is only written for dataases >= 4.1 - so it should be save to add the third parameter with true.

@AlBundy33
Copy link
Author

AlBundy33 commented Mar 3, 2023

I was able to build keeweb with my modification, saved a database in kdbx3 und kdbx4 format and successfully opened then in keepass.

https://github.com/AlBundy33/keeweb_kdbx4_hotfix

AlBundy33 added a commit to AlBundy33/kdbxweb that referenced this issue Mar 3, 2023
to fix error message in keepass see keeweb#49
@Aetherinox
Copy link

Thanks for submitting this. I was recently added onto the team; so I'm getting adjusted to the structure of the code and we've started up development on KeeWeb again.

So let me review these changes, run some tests to ensure it doesn't break anything, and I'll update you.

@Aetherinox Aetherinox added ⚠ Urgent Requires urgent attention Type ◦ Bug Something isn't working labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type ◦ Bug Something isn't working ⚠ Urgent Requires urgent attention
Projects
None yet
Development

No branches or pull requests

2 participants