Add connection pid monitoring #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: To monitor cowboy's connection process, instead of request process. Fixes: keichan34#64
|
Also, I updated the example app with more tests and better readme: https://github.com/scarfacedeb/exfile_sendfile_example |
|
@scarfacedeb Looks good! I haven't tested it, but it looks like this should work with both Cowboy 1 and 2, right? |
|
@keichan34 Thanks! I checked it and it fallbacks to |
|
I'll merge this and get around to releasing a new version, hopefully this week. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start #64.
It should solve the connection monitoring issue with temp files.
I read the cowboy source code and noticed that it always sends the response from the connection process, not the request one.
It means that we have to pass the connection pid from the
Plug.Conndown to theExfile.Tempfile, creating some ugly code as a result. But at least it relies on the least amount of hacks and avoids having separate cleaning worker.@keichan34 what do you think?