Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drain timeout flag for node reaper #45

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

viveksyngh
Copy link
Contributor

Fixes: #42

Signed-off-by: Vivek Singh svivekkumar@vmware.com

@viveksyngh viveksyngh requested a review from a team as a code owner November 13, 2020 05:41
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #45 (241cb9d) into master (c4aa4b4) will decrease coverage by 0.41%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   57.18%   56.77%   -0.42%     
==========================================
  Files           5        5              
  Lines         918      923       +5     
==========================================
- Hits          525      524       -1     
- Misses        330      336       +6     
  Partials       63       63              
Impacted Files Coverage Δ
pkg/reaper/nodereaper/nodereaper.go 45.49% <0.00%> (-0.58%) ⬇️
pkg/reaper/nodereaper/types.go 100.00% <ø> (ø)
pkg/reaper/nodereaper/helpers.go 60.71% <100.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4aa4b4...241cb9d. Read the comment docs.

Fixes: keikoproj#42

Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
@viveksyngh
Copy link
Contributor Author

@eytan-avisror @vgunapati I have updated the PR. Please have look at it.

@eytan-avisror eytan-avisror merged commit a6dff72 into keikoproj:master Jan 7, 2021
shaoxt pushed a commit to shaoxt/governor that referenced this pull request Dec 21, 2021
Fixes: keikoproj#42

Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce flag for drain timeout
4 participants