Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Metrics for Pod/Node Reaper #64

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

eytan-avisror
Copy link
Collaborator

This exposes basic metrics for both pod & node reaper

Eytan Avisror added 3 commits January 24, 2022 18:25
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
@eytan-avisror eytan-avisror requested a review from a team as a code owner January 25, 2022 22:56
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #64 (ad167f1) into master (249d5fd) will decrease coverage by 0.53%.
The diff coverage is 31.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   60.19%   59.66%   -0.54%     
==========================================
  Files          11       11              
  Lines        1510     1537      +27     
==========================================
+ Hits          909      917       +8     
- Misses        506      524      +18     
- Partials       95       96       +1     
Impacted Files Coverage Δ
pkg/reaper/podreaper/types.go 100.00% <ø> (ø)
pkg/reaper/nodereaper/types.go 65.51% <20.00%> (-23.96%) ⬇️
pkg/reaper/podreaper/podreaper.go 73.30% <33.33%> (-2.30%) ⬇️
pkg/reaper/nodereaper/nodereaper.go 46.72% <40.00%> (-0.07%) ⬇️
pkg/reaper/common/prom.go 63.63% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249d5fd...ad167f1. Read the comment docs.

Copy link
Contributor

@shaoxt shaoxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit f9369ac into keikoproj:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants