Add capability to reap EC2 nodes not managed by ASG #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terence Ho <terence.ho@tasktop.com>
tasktop-teho
force-pushed
the
feature/ec2reap
branch
from
154f873
to
82832f9
Compare
|
Can you share some details of the testing done for this PR? Would governor now work for both ASGs and non-ASGs? If a cluster has a mix of some nodes in an ASG and some that aren't, would governor correctly terminate the appropriate instance? |
|
Our cluster has a mix of ASG and non-ASG managed nodes, and my change was able to reap both. I am trying to understand the tests in this repo, and will try to add tests for my changes. Thanks @shrinandj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #70