More optimization work. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PlayerRef property to all instances of FV_SwallowScript. Explanation for PlayerRef over Game.GetPlayer() http://gamesas.com/best-practices-papyrus-t291375.html Also scrapped old percentage calculation functionality, this is slow. Used GetValuePercentage() in its' place.
keilladraconis
approved these changes
Nov 29, 2021
| @@ -64,25 +64,17 @@ Group Scripts | |||
| EndGroup | |||
|
|
|||
| Group Actors | |||
| Actor Property PlayerRef Auto Const Mandatory ;GAZ: This script previously called Game.GetPlayer() so many times that it was worth sacrificing this small amount of script memory for a property, to scrap those calls. Documentation: http://gamesas.com/best-practices-papyrus-t291375.html | |||
There was a problem hiding this comment.
Love the documentary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick function replacement and PlayerRef property added.