Add support for the iCalendar CLASS property #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lisp/org.el (org-mode): Don't modify syntax entry for "@" globally. This syntax entry dates from commit fe939ec when it was used to allow "@" in tags. Now "@" is a word constituent in tags, not anywhere.
* lisp/org.el (org-mode): Let < and > be recognized as opening and ending characters. These characters are typically used in timestamps where it is useful to use C-M-f and C-M-b to manipulate them.
Thanks to Allen Li for pointing this.
* lisp/org.el (org-set-tags-command): Improve docstring.
* contrib/lisp/org-collector.el (org-propview-collect): Inhibit lisp evaluation of headlines This fixes org-collector usage for items starting with a hyperlink, which would be incorrectly treated as lisp code.
* lisp/org.el (org-fast-tag-selection): Fix "(wrong-number-of-arguments max 0)" error when setting tag and no tag is defined.
* lisp/org-agenda.el (org-search-view): Remove agenda-archives even with buffer restriction.
* lisp/org-agenda.el (org-tags-view): Don't leave an empty *Org agenda* buffer when keyboard-quitting the match prompt. Thanks to Xu Chunyang for reporting this.
* lisp/org-clock.el (org-clocktable-defaults) (org-clocktable-write-default, org-clock-get-table-data): Rename :tags to :match and use :tags to insert a column with the headline's tags. Thanks to Raymond Zeitler for suggesting this.
* lisp/org-agenda.el (org-agenda-bulk-action): When there is no mark, act on the agenda entry at point. Thanks to Marco Wahl for suggesting this.
* lisp/org-attach.el: (org-attach-annex-get-maybe) Ensure shell command that checks whether a git-annex file exists is called from within the git-annex repository. Otherwise, it will result in an error.
* lisp/org.el (org-modules): Add org-tempo to the list of default modules. Template expansion is likely to be expected by many users, as it was on by default in previous releases. Let's load org-tempo by default and let users remove it. If needed, we can remove this in future releases.
* lisp/org.el (org-modules): Add org-eww to the list of default modules.
* lisp/org.el (org-open-at-point-global): Use `thing-at-point' to match possibly more urls and emails. Enhance docstring.
* lisp/org.el (org-open-link-from-string): Fix bug when links contain special characters. Thanks to Joon Ro for reporting this.
* lisp/org-agenda.el (org-agenda-get-deadlines): Fix bug when getting the warning delay of a deadline. Thanks to Alex Branham for reporting this.
* lisp/org-src.el (org-src-mode-configure-edit-buffer): Don't set `buffer-file-name'. Thanks to Clément Pit-Claudel for reporting this.
* lisp/org-colview.el (org-columns--display-here-title): Possibly take linum-offset into account. Thanks to Eric S Fraga for reporting this.
* lisp/org.el (org-move-subtree-down): Remove special whitespace treatment. * testing/lisp/test-org.el (test-org/drag-element-backward): Accommodate test.
* ob-scheme.el (org-babel-execute:scheme): Process the :result header argument to conditionally and appropriately format output. Currently, `org-babel-execute:scheme' ignores the user specified :result header argument found in the :result-param parameter and process all output as a table. The fix is to pass the `result' and :result-param to the `org-babel-result-cond' function to invoke the corresponding formatting. For example, the following block incorrectly formats its output as a table: (list 1 2 3) | 1 | 2 | 3 | This patch results in the correct behavior: (list 1 2 3) : (1 2 3) Bringing it inline with the result using Emacs lisp: (list 1 2 3) : (1 2 3)
* test-ob-scheme.el (test-ob-scheme/verbatim, test-ob-scheme/list): New tests.
* lisp/org.el (org--align-tags-here): Correctly preserve column. * testing/lisp/test-org.el (test-org/tag-align): Add test. The regression was introduced in 593058e. Reported-by: Bernt Hansen <bernt@norang.ca> <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00245.html>
* doc/org-manual: All occurrences of "the cursor" are replaced with "point". Begin changing "function" to "Lisp function" as used in the Emacs manual.
* doc/org-manual.org (Using the Mapping API): Add `code' markup around ~save-excursion~, since this is an Elisp special form.
* doc/org-manual.org (Handling Links): Downcase tags. Add a link to explicit what a "tags view" is.
…ale-in-agenda-at-reload
* lisp/ob-core.el (org-babel-sha1-hash): Add optional argument to specify context. (org-babel-execute-src-block): Use new argument. * lisp/ob-exp.el (org-babel-exp-src-block): Use new argument. (org-babel-exp-results): Fix context. Reported-by: Ken Mankoff <mankoff@gmail.com> <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00117.html>
* contrib/lisp/ox-koma-letter.el (org-koma-letter--build-settings): Do not translate closing part twice. Reported-by: Tobias Zawada <i_inbox@tn-home.de> <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00315.html>
* lisp/org-clock.el (org-clock-put-overlay): Do not expand links when displaying clocked times. Reported-by: Sheng Yang (杨圣) <yangsheng6810@gmail.com> <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00024.html>
* lisp/org-agenda.el (org-agenda-mode): Factored out a function for a loop occuring two times. * testing/lisp/test-org-agenda.el: test the text scale after agenda-undo.
* lisp/org-footnote.el (org-footnote-goto-previous-reference): Only add to mark ring on a successful match. Improve error message when reference is outside visible part of buffer. (org-footnote-get-next-reference): Avoid using `org-footnote-at-reference-p', which is inaccurate, due to `org-footnote-in-valid-context-p'. * testing/lisp/test-org-footnote.el (test-org-footnote/goto-previous-reference): New test.
* lisp/org-footnote.el (org-footnote-at-reference-p): (org-footnote-at-definition-p): Rewrite using Elements library. (org-footnote-get-next-reference): Use `org-footnote-at-reference-p'. (org-footnote-next-reference-or-definition): Use old definition for `org-footnote-at-definition-p' and `org-footnote-at-definition-p'. This patch aims at reducing the calls to the inaccurate `org-footnote-in-valid-context-p' function. However, `org-footnote-next-reference-or-definition' still uses it because the function is for fontification only, so 1. accuracy matters less 2. Elements has a slower worse case scenario.
* lisp/org-footnote.el (org-footnote-next-reference-or-definition): Fix typo introduced in last commit.
* lisp/org-info.el (org-info-follow-link): Fix typo in regexp.
* doc/org-manual.org (Packages that Org cooperates with): (Footnotes): Use "::" as node separator instead of ":".
* doc/org-manual.org (Code Evaluation and Security Issues): (Structure of Code Blocks): (Packages that Org cooperates with): Fix case.
* doc/org-manual.org (Basic TODO Functionality): (Priorities): (Timestamps, Deadlines and Scheduling): (Agenda Views): (Change display): (Footnotes): Remove references to the now removed "timeline" feature.
* doc/org-manual.org (Formula syntax for Calc): Add zero width spaces to avoid unwanted markup.
* doc/org-manual.org (The clock table): Add missing "=" markup for parts of an Org buffer. Add "@noindent" directives.
* doc/org-manual.org (Setting options for custom commands): Use lower case for user defined example tags.
* doc/org-manual.org (The clock table): Add missing {{{var(...)}}}
markup.
* doc/org-manual.org (The clock table): Add missing markup for properties.
…nces * doc/org-manual : More wording and grammar is fixed, cross-references to other sections are added when key terms appear (e.g. agenda, property, completion).
* lisp/org.el (org-effort-duration): Remove unused variable. * lisp/org-compat.el (org-effort-durations): Make `org-effort-duration' an alias for `org-duration-units'. * lisp/org-clock.el (org-clock-modify-effort-estimate): Fix docstring. * doc/org-manual.org (Footnotes): Clarify footnote. The variable is inactive since introduction of "org-duration" library.
* ox-icalendar.el (org-icalendar-entry): Pick the CLASS property and pass it to `org-icalendar--vevent' and `org-icalendar--vtodo'. (org-icalendar--vevent,org-icalendar--vtodo): Add a new parameter `class' and use it to generate a `CLASS' field in the `VEVENT' entry. TINYCHANGE
* doc/org-manual.org (iCalendar export): Document the CLASS tag
TINYCHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property and pass it to
org-icalendar--vevent' andorg-icalendar--vtodo'.(org-icalendar--vevent,org-icalendar--vtodo): Add a new parameter
class' and use it to generate aCLASS' field in the `VEVENT'entry.
TINYCHANGE