fix: fix incorrect base64 padding assumption #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keirlawson
reviewed
Mar 6, 2024
|
I added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an oversight in 789d5ef, the previous decode call was replaced with the STANDARD_NO_PAD engine, which is not the correct engine to use. The previous decode function was indifferent to the padding, hence it passed the test and also worked on an actual config.json file. However, the config.json file always contains PADDED base64, so the library is now not working in the real world.
This PR introduces a custom engine config with indifferent padding to replicate the previous behavior.