Revisit game actions #273
Merged
Revisit game actions #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move meta actions `resume_move` and `move_to` out of game actions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
keis
commented
Jan 3, 2024
| let Some(system) = systems.get(action.action_type) else { | ||
| return Ok(()); | ||
| }; | ||
| world.run_system(system) |
There was a problem hiding this comment.
TODO, decouple action implementations from queue by passing action as input to system
* Action type as enum without any containing data * Standard action parameters (source, targets) defined in struct * Action systems stored in resource and dispatched by world exclusive handler system Fixes #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor game actions
handler system
Fixes #45