Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OnceExit to ensure hashing is done after other plugins #27

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

koddsson
Copy link
Contributor

The PostCSS docs are pretty minimal, but I think this will fix an issue I was having where PostCSS would do hashing on un-minified CSS files, and then it would minify, causing hash mismatches in my project.

https://postcss.org/api/#plugin-onceexit

@keithamus keithamus merged commit bcaec50 into keithamus:master Jun 11, 2021
@keithamus
Copy link
Owner

@dacodekid would you be able to give @koddsson commit access to this repo? @koddsson is a colleague of mine and we’re both working on this package now.

@dacodekid
Copy link
Collaborator

dacodekid commented Jun 14, 2021

@keithamus .. just sent a Collaborator invitation to @koddsson. If you would prefer, I don't mind change this repo's ownership to yourself as well. Plz let me know.

@keithamus
Copy link
Owner

Might be easier so I can administer it easier, but I don't want to steal the credit for the great work you did! Up to you 😜

@dacodekid
Copy link
Collaborator

Not at all. Haven't done anything like it before. Let me search it through and will start the process immediately.

@dacodekid
Copy link
Collaborator

image

When I tried, getting this error. Not sure what to do here :(

@keithamus
Copy link
Owner

That'll be my fork. I've just deleted it so it should be good to go now!

@dacodekid
Copy link
Collaborator

@keithamus transfer request has been sent. Should I do this for npm as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants