Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct node name for npm-package-json-lint #236

Merged
merged 1 commit into from
Nov 12, 2021
Merged

fix: use correct node name for npm-package-json-lint #236

merged 1 commit into from
Nov 12, 2021

Conversation

shaneog
Copy link
Contributor

@shaneog shaneog commented Nov 11, 2021

It used to be npmpkgjsonlint, then npmPackageJsonLintConfig and now it's npmpackagejsonlint as of v4+.

The npm-package-json-lint package is currently at v5.4.1

@shaneog
Copy link
Contributor Author

shaneog commented Nov 11, 2021

This could be considered a breaking change, so I can change the commit message to reflect that if you would like @keithamus?

@keithamus
Copy link
Owner

We could add all three keys next to each other. I don't think it'll impact this project all too much and it certainly would be less breaking for folks.

@shaneog
Copy link
Contributor Author

shaneog commented Nov 11, 2021

Done

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@keithamus keithamus merged commit 668b47f into keithamus:master Nov 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.53.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants