feat: allow script sort for run-p #240
Conversation
brodyd795
changed the title
|
@keithamus Is there anything I can do to help in order to get this one merged? |
|
Sure! I hadn't noticed this PR before as it's a draft and so didn't end up in my inbox. So to start I'd say taking this PR and making it a non-draft PR would be a good first step! |
@brodyd795 Can we set this PR 'ready for review' please? |
| if (hasDevDependency('npm-run-all', packageJson)) { | ||
| const scripts = packageJson.scripts | ||
| const betterScripts = packageJson.betterScripts | ||
|
|
||
| if (scripts) { | ||
| return Object.values(scripts).some((script) => | ||
| runSValues.some((runSValue) => runSValue.test(script)), | ||
| ) | ||
| } | ||
|
|
||
| if (betterScripts) { | ||
| return Object.values(betterScripts).some((script) => | ||
| runSValues.some((runSValue) => runSValue.test(script)), | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
What about an early return here?
| if (hasDevDependency('npm-run-all', packageJson)) { | |
| const scripts = packageJson.scripts | |
| const betterScripts = packageJson.betterScripts | |
| if (scripts) { | |
| return Object.values(scripts).some((script) => | |
| runSValues.some((runSValue) => runSValue.test(script)), | |
| ) | |
| } | |
| if (betterScripts) { | |
| return Object.values(betterScripts).some((script) => | |
| runSValues.some((runSValue) => runSValue.test(script)), | |
| ) | |
| } | |
| } | |
| return false | |
| if (!hasDevDependency('npm-run-all', packageJson)) { | |
| return false | |
| } | |
| const scripts = packageJson.scripts | |
| const betterScripts = packageJson.betterScripts | |
| if (scripts) { | |
| return Object.values(scripts).some((script) => | |
| runSValues.some((runSValue) => runSValue.test(script)), | |
| ) | |
| } | |
| if (betterScripts) { | |
| return Object.values(betterScripts).some((script) => | |
| runSValues.some((runSValue) => runSValue.test(script)), | |
| ) | |
| } |
| const toReturn = sortObjectKeys(scripts, order) | ||
|
|
||
| return sortObjectKeys(scripts, order) | ||
| return toReturn |
There was a problem hiding this comment.
Since we're only using toReturn as a return value, I think we can just keep it as it was?
| const toReturn = sortObjectKeys(scripts, order) | |
| return sortObjectKeys(scripts, order) | |
| return toReturn | |
| return sortObjectKeys(scripts, order) |
|
@MichaelDeBoey given this PR is coming on for a year old, you might consider forking it and making a new PR. You can keep @brodyd795's commits in, which means you'll both get contribution credit! |
Background
This package does not currently support sorting the
scriptsfield of apackage.jsonwhennpm-run-allis a devDependency, regardless of how it is actually used in the scripts.While there is certainly a place for refraining from sorting the scripts when
npm-run-allis used for running scripts sequentially (e.g.npm-run-all --serial), there are use cases where the user may wish for the scripts to be sorted even whennpm-run-allis a devDepenency (e.g.npm-run-all -p). This concern has been raised in previous PRs and issues (see this PR and this issue).This PR enables this behavior.
Changes
The following uses of
npm-run-allwill continue to NOT sort thescripts:npm-run-allnpm-run-all --serialnpm-run-all --sequentialnpm-run-all -srun-sWhile the following uses now WILL sort the
scripts:npm-run-all --parallelrun-p