-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for react-native key #243
Conversation
See the following line for React Native's package resolution strategy: https://github.com/facebook/metro/blob/347b1d7ed87995d7951aaa9fd597c04b06013dac/packages/metro/src/DeltaBundler/__tests__/resolver-test.js#L73
@angeloashmore looks like you'll need to update the tests to get this passing and mergeable. |
@keithamus Thanks for taking a look at this. Yes, I will update the snapshots, but I'm having trouble installing the dependencies locally. I get this ENOTFOUND error when running
Indeed, that address does not point to anywhere on my network. Is there something I'm supposed to set up? |
Looks like a PR leaked custom proxies into the package-lock; #206. If you remove the package-lock.json and re-run |
Thanks, I wasn't sure if those URLs were intentional. I've updated I believe it should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and perseverance here!
🎉 This PR is included in version 1.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No problem! 🙂 Thanks for sticking with me, too! |
Adds support for the
react-native
key for packages providing a React Native-specific entry.See the following line for React Native's package resolution strategy (via Metro): https://github.com/facebook/metro/blob/347b1d7ed87995d7951aaa9fd597c04b06013dac/packages/metro/src/DeltaBundler/__tests__/resolver-test.js#L73