Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for react-native key #243

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

angeloashmore
Copy link
Contributor

Adds support for the react-native key for packages providing a React Native-specific entry.

See the following line for React Native's package resolution strategy (via Metro): https://github.com/facebook/metro/blob/347b1d7ed87995d7951aaa9fd597c04b06013dac/packages/metro/src/DeltaBundler/__tests__/resolver-test.js#L73

keithamus
keithamus previously approved these changes Jan 29, 2022
@keithamus
Copy link
Owner

@angeloashmore looks like you'll need to update the tests to get this passing and mergeable.

@angeloashmore
Copy link
Contributor Author

@keithamus Thanks for taking a look at this. Yes, I will update the snapshots, but I'm having trouble installing the dependencies locally.

I get this ENOTFOUND error when running npm i:

npm ERR! code ENOTFOUND
npm ERR! syscall getaddrinfo
npm ERR! errno ENOTFOUND
npm ERR! network request to https://nexus.core.cvent.org/nexus/repository/npm-public/typescript/-/typescript-4.0.5.tgz failed, reason: getaddrinfo ENOTFOUND nexus.core.cvent.org
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

Indeed, that address does not point to anywhere on my network.

Is there something I'm supposed to set up?

@keithamus
Copy link
Owner

keithamus commented Jan 31, 2022

Looks like a PR leaked custom proxies into the package-lock; #206.

If you remove the package-lock.json and re-run npm i it should fix things.

@angeloashmore
Copy link
Contributor Author

Thanks, I wasn't sure if those URLs were intentional. I've updated package-lock.json and snapshots.

I believe it should be good to go now.

Copy link
Owner

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience and perseverance here!

@keithamus keithamus merged commit 0a3273f into keithamus:master Feb 2, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

🎉 This PR is included in version 1.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@angeloashmore
Copy link
Contributor Author

No problem! 🙂 Thanks for sticking with me, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants