Uses cross-spawn-async for Windows compatibility

[IrregularShed]

Replaced child_process.spawn with cross-spawn-async for cross-platform
compatibility. (Windows command line has problems with
child_process.spawn.)

[keithwhor]

Can you write tests for this? I'd like confirmation that this works on all environments, because I haven't spun up a VM with Windows myself. We can test on more environments on TravisCI.

[keithwhor]

Great work and thank you very much, btw :)

[IrregularShed]

👍 I'll try and get proper tests written over the weekend (unexpectedly busy afternoon in the office, otherwise I'd have had a go already). So far the testing has been "does this work on my Windows machine" (it does) and Travis giving the thumbs up :)

[IrregularShed]

(Travis testing on non-Windows boxes I mean by that)

[keithwhor]

Thanks so much! Understand the busy office situation. Same here. ;)

[schahriar]

@keithwhor considering that you can't run Windows tests on Travis do you plan to intergrate something like appveyor for the tests? I can write the test (depending on what you would expect) as I am in dire need for this PR to be merged so I can develop on my Windows setup.

[IrregularShed]

Tests are going to be hard to achieve for a while - I'm having an absolute nightmare getting the tests to start on Windows. Adjusting the child_process.execSync() commands in runner.js so that \' are replaced with " was enough to get the postgres commands to at least run, but the command for creating the database fails completely when I try and call it from within Node (either in the test script or directly from the REPL) - the process shudders to a halt and remains unresponsive.

[keithwhor]

Hey, if you guys are confident this works as intended I have no problem merging at this point. If tests are a nightmare let's just not worry about it.

[schahriar]

That sounds awful :( I might give it a go today and see what I can do. Is this only applicable to runner.js? psql -c \'create database nodal_test;\' -U postgres I think this is the command you are referring to. @keithwhor I haven't tested the PR so don't take my word for it. I believe we should test this properly before leaving the chance for crashing the entire ecosystem (since we rely on child_process to do db stuff)

[schahriar]

@keithwhor are you working on an db adapter system like sails' waterline or sticking with SQL for now? Because we could re-write this in the new CLI changes.

[keithwhor]

@schahriar We have a built in db adapter system, not sure what you're asking?

[schahriar]

@keithwhor I was referring to support for other databases (MySQL, Mongo, etc.) but nvm I confused runner.js with the rest of the code forgetting that it was part of the test. cli.js seems to use ./db/commands.js which is what I was looking for.

[schahriar]

@IrregularShed I got runner.js & tests working and from what I see this is mostly because of psql response speed also needed an -a option for some reason. Add me as a collaborator to your fork so I can push the changes to this PR.

[IrregularShed]

@schahriar You're added :)

[schahriar]

Seems like fixes for Windows are breaking everything else. I'll setup a bunch of test servers to test the latest commit before pushing it to the CI.

[keithwhor]

Looks good to me. Ran fine.