Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node-i2c compile with Node 4. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make node-i2c compile with Node 4. #70

wants to merge 1 commit into from

Conversation

polaris
Copy link

@polaris polaris commented Oct 26, 2015

  • v8::Buffer::New returns an instance of v8::MaybeLocal<>
  • an instance of v8::MaybeLocalv8::Object needs to be asked for the actual local
    by calling v8::MaybeLocalv8::Object::ToLocalChecked()

* v8::Buffer::New returns an instance of v8::MaybeLocal<>
* an instance of v8::MaybeLocal<v8::Object> needs to be asked for the actual local
  by calling v8::MaybeLocal<v8::Object>::ToLocalChecked()
@seriousManual
Copy link

NaN (https://github.com/nodejs/nan) abstracts such native incompatabilities that are introduced with every new v8 version

@bchr02
Copy link

bchr02 commented Dec 30, 2015

+1 to get a working solution merged!

@kelly
Copy link
Owner

kelly commented Dec 30, 2015

Thanks for this pr! Moving forward I'm looking to integrate NaN so these issues don't arise again. Unfortunately, using NaN requires almost a full re-write.

@saasmath
Copy link

@kelly: I would encourage you to merge the PR rather than waiting for the time to do a re-write for NaN. While it is a bit of a hack, when one uses your module because a dependency from npm, it will nearly always break those modules if they are running a currently supported version of node.

@rzr
Copy link

rzr commented Jul 3, 2019

May this change:
#96

supersede this PR
#70

I didn't check on node-4

@rzr
Copy link

rzr commented Feb 24, 2020

May you try to submit to this fork:
https://github.com/abandonware/node-i2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants