ember-cli@2.10.0 #159
Merged
ember-cli@2.10.0 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ember-cli/ember-cli#6496 stops this |
kellyselden
force-pushed
the
ember-cli@2.10.0
branch
from
851e779
to
1e2c467
Compare
mriska
reviewed
Dec 4, 2016
| "ember-cli-qunit": "^3.0.1", | ||
| "ember-cli-release": "^0.2.9", | ||
| "ember-cli-sri": "^2.1.0", | ||
| "ember-cli-test-loader": "^1.1.0", | ||
| "ember-cli-uglify": "^1.2.0", | ||
| "ember-data": "^2.9.0", | ||
| "ember-data": "^2.10.0", |
There was a problem hiding this comment.
Question: Do you actually use ember-data in this addon or could this dependency be removed?
There was a problem hiding this comment.
Yes, some of the promise macros use mixins from it. But I'm totally open to extracting those macros out to remove the ember-data dependency.
There was a problem hiding this comment.
Ah, ok. just thought it might be totally unused and just part of the basic addon scaffolding.
There was a problem hiding this comment.
added tracking issue #102
kellyselden
force-pushed
the
ember-cli@2.10.0
branch
from
1e2c467
to
940005f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.