Fix type reporting for types that are slices #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.IP is defined as: type IP []byte prior to this PR, envconfig was interpretting that type of anything that was a slice of uint8 (including []byte) as a String. That is the correct behavior if you really have a []uint8, but types that *happen* to be []uint8 should be reported as their actual type. Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.IP is defined as:
type IP []byte
prior to this PR, envconfig was interpretting that type of anything
that was a slice of uint8 (including []byte) as a String.
That is the correct behavior if you really have a []uint8,
but types that happen to be []uint8 should be reported
as their actual type.
Signed-off-by: Ed Warnicke hagbard@gmail.com