Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type reporting for types that are slices #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type reporting for types that are slices #172

wants to merge 1 commit into from

Commits on May 23, 2020

  1. Fix type reporting for types that are slices 

    net.IP is defined as:

type IP []byte

prior to this PR, envconfig was interpretting that type of anything
that was a slice of uint8 (including []byte) as a String.

That is the correct behavior if you really have a []uint8,
but types that *happen* to be []uint8 should be reported
as their actual type.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
    @edwarnicke
    edwarnicke committed May 23, 2020
    Configuration menu
    Copy the full SHA
    4e80799 View commit details
    Browse the repository at this point in the history