Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig file #3153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rylek90
Copy link

@rylek90 rylek90 commented Jul 12, 2019

Quite often when we write nocode in our internal application we argue over really small things.

Should it be:


or? 🤔


Is something like this even properly formatted?


This PR adds .editorconfig file, which will save us (and other users) from headache! ✨

@sheldonhull
Copy link

You've finally solved 'tabs vs spaces'. 🎉 this is an epic moment for sure

Copy link

@sheldonhull sheldonhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait... how do I have rights to approve such a drastic change? I just noticed I could finish a review. Pray tell? @kelseyhightower does this mean we can all add reviews to ensure the quality of contributions remain high? 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants