fix: ensure webhook.events & webhook.signing_secret changes are detected correctly #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://developer.hashicorp.com/terraform/plugin/framework/handling-data/attributes#set This also ensures the order of items does not matter. We also get uniqueness verified for free. Addresses #45
…hy this is suddenly failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
This PR fixes the detection of changes for the
circleci_webhookresource.Specifically we modified the following:
eventssigning_secretAlso modified the
circleci_webhooksdata source foreventsattribute.Importantly, we also added an additional test to confirm no changes to plan are detected if the
circleci_webhookresource definition did not change indeed.