Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ameba on Travis CI #520

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Use Ameba on Travis CI #520

merged 1 commit into from
Jun 13, 2019

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Feb 6, 2019

Because linting is caring :)

jkthorne
jkthorne reviewed Feb 8, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@sdogruyol
Copy link
Member

@Sija I'm not totally sure about this...yet

wisn
wisn reviewed Mar 28, 2019
View reviewed changes
Copy link

@wisn wisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there several unrelated changes made as well? Like, you are changing src/kemal/exception_handler.cr which is unrelevant to Ameba on Travis CI at all.

@Blacksmoke16
Copy link
Contributor

@wisn That change was probably to get ameba to pass, due to the like unnecessary return assertion. Since it was the last thing, the return keyword is not needed.

@wisn
Copy link

wisn commented Mar 28, 2019

@Blacksmoke16 Ah, that makes sense to me.

alex-lairan
alex-lairan approved these changes Mar 29, 2019
View reviewed changes
Copy link

@alex-lairan alex-lairan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is love ❤️

@Sija
Copy link
Contributor Author

Sija commented May 18, 2019

@sdogruyol any decisions? 🏓

@bararchy
Copy link

+1 for ameba !

sdogruyol
sdogruyol approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sija 👍

@sdogruyol sdogruyol merged commit 06665e8 into kemalcr:master Jun 13, 2019
@mamantoha mamantoha mentioned this pull request Jun 14, 2019
Merged
@Sija Sija mentioned this pull request Aug 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkthorne jkthorne jkthorne left review comments

@wisn wisn wisn left review comments

@Blacksmoke16 Blacksmoke16 Blacksmoke16 approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

@alex-lairan alex-lairan alex-lairan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sija @sdogruyol @Blacksmoke16 @wisn @bararchy @jkthorne @alex-lairan