Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make routes behind locale block work #3

Closed
wants to merge 1 commit into from

Conversation

jonduarte
Copy link

I'm using this gem in a small project that I have, when I cloned it a notice that one spec is failing.
It seems that because we are having a global matcher on the locale route we cannot match routes that are below the locale block.

My approach to fix this is to route only to the ones available, based on R18n.available_locales.
Let me know what do you think of this, wether this approach makes sense.

PS: the change is pretty small, however my editor automatically removes trailing whitespace, hope you don't mind.

@kematzy
Copy link
Owner

kematzy commented Aug 8, 2016

Hi Jonathan,

Thanks a lot for your PR and contribution! Much appreciated.

Your PR looks OK to me, so I will merge this after running some quick verification tests tomorrow.

As for the spaces, I may just do a new commit with your actual code changes, with credit to you, so that your addition is clearer (less noise) and then do another commit removing the spaces.

@jonduarte
Copy link
Author

Cool! thanks for taking the time to look into this.

kematzy added a commit that referenced this pull request Aug 11, 2016
Big THANK YOU! to @jonduarte for his fix of this issue and pull request.

Note: Although I could have done a straight merge, I chose to add it after confirming that the issue existed previously (which it did) and @jonduarte’s fix solves the problem.
@kematzy
Copy link
Owner

kematzy commented Aug 11, 2016

Hi Jonathan,

I have committed your PR code changes and given you credit for those additions as you can see above.

I will therefore close this PR as the remaining changes in your PR are mainly to do with whitespace formatting.

Thanks again for your help with this!

@kematzy kematzy closed this Aug 11, 2016
@jonduarte
Copy link
Author

Hi Kematzy, no problem, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants