Make routes behind locale block work #3
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this gem in a small project that I have, when I cloned it a notice that one spec is failing.
It seems that because we are having a global matcher on the locale route we cannot match routes that are below the locale block.
My approach to fix this is to route only to the ones available, based on
R18n.available_locales
.Let me know what do you think of this, wether this approach makes sense.
PS: the change is pretty small, however my editor automatically removes trailing whitespace, hope you don't mind.