Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CSS using Mozilla Developer Network (MDN) #35

Merged
merged 1 commit into from
Jun 22, 2014

Conversation

druellan
Copy link

Ported from the cssDOC plugin (https://sublime.wbond.net/packages/cssDOC), using MDN to link documentation. Works pretty well and Mozilla is doing a complete revision of their documentation.
Kudos to @chrissimpkins for the idea.

@chrissimpkins
Copy link

@druellan : Note that the URL that you submitted in this pull request:

http://developer.mozilla.org/en-US/docs/Web/CSS/{keyword}

requires a supported keyword to identify the file. If there are extra spaces/colons/or it is simply not a CSS entity, then you'll get a 404 page. If you are looking for search, it is the following URL:

http://developer.mozilla.org/en-US/search?q={keyword}&topic=css.

I am using the second one as a fallback if the user's request doesn't parse to an actual CSS entity. Feel free to grab and use the Python list in my project (contains all of the CSS entities from the MDN site) if it is helpful to you.

Hope it helps,
C

@druellan
Copy link
Author

Thanks Chris, In truth, didn't want to rip-off your code, but now that I have your blessing, I'll try to integrate it.
Thanks again.

@chrissimpkins
Copy link

No worries at all. Hope the code helps.

C

@druellan
Copy link
Author

Yes, but I think I'll leave it as is, since it is more or less the same thing other implementations are doing. I don't want to introduce better string sanitization and detection just for CSS: this should be implemented on the plugin itself.
In sum, I think it is ok. Perhaps @kemayo can give us some input about that.

@royduin
Copy link

royduin commented Mar 25, 2014

This is what I'm looking for, can this be added in the next version?

kemayo added a commit that referenced this pull request Jun 22, 2014
Support for CSS using Mozilla Developer Network (MDN)
@kemayo kemayo merged commit 01cc2ae into kemayo:master Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants