Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of included files #30

Closed
wants to merge 0 commits into from
Closed

Add number of included files #30

wants to merge 0 commits into from

Conversation

mruz
Copy link
Contributor

@mruz mruz commented Oct 28, 2015

No description provided.

@mruz
Copy link
Contributor Author

mruz commented Oct 28, 2015

What do you think about this changes?
benchmark

@kenjis
Copy link
Owner

kenjis commented Oct 28, 2015

It is interesting, but I can't accept the changes. Because I have more than 20 frameworks.
The graph would be too large.

By the way, why your Phalcon and Ice are so faster than other PHP implemented frameworks?

@mruz
Copy link
Contributor Author

mruz commented Oct 28, 2015

I don't know, maybe multithreading? I run the benchmark on real machine:
CPU: i7-4702MQ 4 cores 8 threads
RAM: 12 GB
Nginx: 1.8.0
PHP-FPM: 5.6.14

Results for Phalcon and Ice are very similar, sometimes Phalcon is a bit better.

@kenjis
Copy link
Owner

kenjis commented Oct 29, 2015

Thank you for your info! Very interesting.

@kenjis
Copy link
Owner

kenjis commented Oct 29, 2015

I cherry-picked your commits, and added simple theme functionality for graph output.

http://localhost/php-framework-benchmark/?theme=mruz

@motin
Copy link

motin commented Dec 10, 2015

If the changes are cherry-picked, maybe this PR can be closed?

@mruz
Copy link
Contributor Author

mruz commented Dec 10, 2015

How about the commits:

Output, add number of included files mruz@b639da1
Output, add greater accuracy to relative mruz@fbc74c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants