Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header overlapped logo link #3

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Header overlapped logo link #3

merged 1 commit into from
Feb 5, 2019

Conversation

Roy-Orbison
Copy link
Contributor

Using flex to fix it as is simpler and main app CSS already uses flex styles.

@kenlog
Copy link
Owner

kenlog commented Jan 9, 2019

Hi @Roy-Orbison thank you for your cooperation. This problem has been solved with the version v1.2.1

@Roy-Orbison
Copy link
Contributor Author

Not quite. I installed that version today and the <h2> overlaps the clickable logo, creating an unclickable region above it. This patch is a cleaner solution that does not obstruct the logo at all.

@kenlog
Copy link
Owner

kenlog commented Jan 9, 2019

Are you using the Customizer plugin? It's probably because he uses a different template for the header, which I'll have to fix.

@Roy-Orbison
Copy link
Contributor Author

I was when I wrote that patch. I have since uninstalled it, and set the logo to null in your plugin's config.

@kenlog
Copy link
Owner

kenlog commented Jan 9, 2019

Hi @Roy-Orbison ok I also corrected for the Customizer plugin. Try cloning from the master branch. It should be fine now 👍

@kenlog kenlog merged commit d602b40 into kenlog:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants