Fix GH rails#4760. A Block was not evaluated.

kennyj · Jan 31, 2012 · 91700bf · 91700bf · mledom · Jan 31, 2012
1 parent b2955ed
commit 91700bf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/activesupport/lib/active_support/tagged_logging.rb b/activesupport/lib/active_support/tagged_logging.rb
@@ -33,13 +33,14 @@ def silence(temporary_level = Logger::ERROR, &block)
     deprecate :silence
 
     def add(severity, message = nil, progname = nil, &block)
-      @logger.add(severity, "#{tags_text}#{message}", progname, &block)
+      message = (block_given? ? block.call : progname) if message.nil?
+      @logger.add(severity, "#{tags_text}#{message}", progname)
     end
 
     %w( fatal error warn info debug unknown ).each do |severity|
       eval <<-EOM, nil, __FILE__, __LINE__ + 1
         def #{severity}(progname = nil, &block)
-          add(Logger::#{severity.upcase}, progname, &block)
+          add(Logger::#{severity.upcase}, nil, progname, &block)
         end
       EOM
     end

diff --git a/activesupport/test/tagged_logging_test.rb b/activesupport/test/tagged_logging_test.rb
@@ -70,4 +70,12 @@ def flush(*)
       assert_nothing_raised { @logger.silence {} }
     end
   end
+
+  test "calls block" do
+    @logger.tagged("BCX") do
+      @logger.info { "Funky town" }
+    end
+    assert_equal "[BCX] Funky town\n", @output.string
+  end
+
 end