Fix fullurl/editurl, add plaintext extract #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for fullurl and text should start_with, not should.start_with
kenpratt
force-pushed
the
master
branch
3 times, most recently
from
28e1947
to
00c0df0
Compare
pietromenna
added a commit
that referenced
this pull request
Jun 26, 2015
Fix fullurl/editurl, add plaintext extract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Client.request_page method, "info" was missing from :prop, which resulted in the absence of "fullurl" and "editurl" from the JSON response. With this patch, Page.fullurl and Page.editurl return the expected values.
I also added "extracts" to :prop, and included the :explaintext flag, which allows the user to obtain an article extract in plain text via the new Page.text method.