-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sql optionals #528
Sql optionals #528
Conversation
This is a working solution with 2 hacks. Before I address them, I want to first see where the If you think these hacks should be addressed before this PR merges, I'll come back to it after I know where the rest of the pieces in the SQL backend fit in. |
Assuming #531 should merge first, and then we work on removing the hacks here? |
Takeaways from in-person conversation:
After those two steps, this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few suggestions to improve the maintainability of the code.
Implemented:
todo:
([FeedingEvent_3].uuid IS NOT NULL) = 0
as[FeedingEvent_3].uuid IS NULL