Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement recurse in SQL #531

Merged
merged 17 commits into from
Sep 5, 2019
Merged

Implement recurse in SQL #531

merged 17 commits into from
Sep 5, 2019

Conversation

bojanserafimov
Copy link
Collaborator

@bojanserafimov bojanserafimov commented Aug 28, 2019 •
edited
Loading

Implement @recurse in SQL using recursive CTEs.

@obi1kenobi
Copy link
Contributor

If I understood the generated queries correctly (which I very well might not have), I think they might have not been starting at depth 0: https://github.com/kensho-technologies/graphql-compiler#recurse

@bojanserafimov bojanserafimov marked this pull request as ready for review August 29, 2019 14:11
@bojanserafimov
Copy link
Collaborator Author

If I understood the generated queries correctly (which I very well might not have), I think they might have not been starting at depth 0: https://github.com/kensho-technologies/graphql-compiler#recurse

Yeah, a lot of things were wrong. Try now.

obi1kenobi
obi1kenobi reviewed Sep 3, 2019
View reviewed changes
graphql_compiler/compiler/emit_sql.py Outdated Show resolved Hide resolved
graphql_compiler/compiler/emit_sql.py Outdated Show resolved Hide resolved
graphql_compiler/schema/schema_info.py Outdated Show resolved Hide resolved
graphql_compiler/compiler/emit_sql.py Outdated Show resolved Hide resolved
graphql_compiler/schema/schema_info.py Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi mentioned this pull request Sep 3, 2019
Merged
obi1kenobi
obi1kenobi reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise this looks great!

graphql_compiler/compiler/emit_sql.py Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi merged commit 32f3f2f into master Sep 5, 2019
@obi1kenobi obi1kenobi deleted the sql_recurse branch September 5, 2019 15:13
@obi1kenobi obi1kenobi mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bojanserafimov @obi1kenobi